Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(offcanvas): added new module offcanvas. #6424

Open
wants to merge 22 commits into
base: development
Choose a base branch
from

Conversation

SvetlanaMuravlova
Copy link
Contributor

@SvetlanaMuravlova SvetlanaMuravlova commented Jan 26, 2022

feat(offcanvas): added new module offcanvas.

@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 26, 2022 08:11 Inactive
@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 26, 2022 12:52 Inactive
@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 26, 2022 12:53 Inactive
@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 27, 2022 10:22 Inactive
@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 27, 2022 10:31 Inactive
@github-actions
Copy link

github-actions bot commented Jan 27, 2022

Visit the preview URL for this PR (updated for commit 09612d1):

https://ngx-bootstrap-demo--pr6424-offcanvas-module-0p77flqn.web.app

(expires Mon, 10 Oct 2022 13:37:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #6424 (dcf04aa) into development (0380c3c) will increase coverage by 0.22%.
The diff coverage is 57.89%.

❗ Current head dcf04aa differs from pull request most recent head 85d15bf. Consider uploading reports for the commit 85d15bf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6424      +/-   ##
===============================================
+ Coverage        76.42%   76.64%   +0.22%     
===============================================
  Files              315      314       -1     
  Lines            10613    10568      -45     
  Branches          2924     2918       -6     
===============================================
- Hits              8111     8100      -11     
+ Misses            2501     2467      -34     
  Partials             1        1              
Impacted Files Coverage Δ
src/modal/modal-container.component.ts 44.15% <0.00%> (+6.49%) ⬆️
src/modal/public_api.ts 100.00% <ø> (ø)
src/modal/modal.directive.ts 3.66% <12.50%> (-0.42%) ⬇️
src/modal/bs-modal.service.ts 88.28% <100.00%> (+19.70%) ⬆️
src/modal/modal.module.ts 84.61% <100.00%> (-1.10%) ⬇️
src/tooltip/tooltip.directive.ts 57.04% <100.00%> (ø)
src/chronos/i18n/it.ts 80.00% <0.00%> (-20.00%) ⬇️
src/chronos/i18n/uk.ts 87.50% <0.00%> (-3.13%) ⬇️
src/chronos/i18n/cs.ts 88.42% <0.00%> (ø)
src/chronos/i18n/pl.ts 88.52% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0380c3c...85d15bf. Read the comment docs.

@cypress
Copy link

cypress bot commented Jan 27, 2022



Test summary

806 32 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 9d3ff03 ℹ️
Started Oct 3, 2022 1:38 PM
Ended Oct 3, 2022 2:10 PM
Duration 31:30 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


Failures

typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
3 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
4 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
5 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
6 Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
7 Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
This comment includes only the first 10 test failures. See all 32 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 27, 2022 14:59 Inactive
@SvetlanaMuravlova SvetlanaMuravlova changed the title Offcanvas module feat(offcanvas): added new module offcanvas. Jan 27, 2022
@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 28, 2022 07:54 Inactive
@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 28, 2022 08:33 Inactive
@@ -91,6 +91,7 @@ export class ModalContainerComponent implements OnInit, OnDestroy {
@HostListener('click', ['$event'])
onClickStop(event: MouseEvent): void {
const clickedInBackdrop = event.target === this._element.nativeElement && !this.clickStartedInContent;
console.log(clickedInBackdrop);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(clickedInBackdrop);
console.log(clickedInBackdrop);

export class OffcanvasContainerComponent {
_config?: typeof OffcanvasConfig;
id = id++;
@ViewChild(OffcanvasDirective, {static: false}) public directive?: OffcanvasDirective;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@ViewChild(OffcanvasDirective, {static: false}) public directive?: OffcanvasDirective;
@ViewChild(OffcanvasDirective, {static: false}) public offcanvasDirective?: OffcanvasDirective;

@Directive({selector: '[offcanvas]', exportAs:'offcanvas'})
export class OffcanvasDirective {
isOpen = false;
delayValue = 300; // it is necessary for showing several elements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
delayValue = 300; // it is necessary for showing several elements
// it is necessary for showing several elements
delayValue = 300;

backdropScrolling: boolean;
};

export const OffcanvasConfig: OffcanvasConfigType = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be injectable


@Input() set config(value: OffcanvasConfigType | undefined) {
if (!value) {
this.config = Object.assign({}, OffcanvasConfig);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inject OffcanvasConfig as service, to allow app module configuration

_config?: OffcanvasConfigType;

@Input() set config(value: OffcanvasConfigType | undefined) {
if (!value) {
Copy link
Member

@valorkin valorkin Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use as a value
const config = Object.assign({}, OffcanvasConfig, this.offcanvasConfig, value || {})

@@ -0,0 +1,18 @@
export type AvailablePlacement = 'start' | 'end' | 'top' | 'bottom';
export type OffcanvasConfigType = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial

@valorkin valorkin temporarily deployed to ngx-bootstra-offcanvas--tiajai January 28, 2022 12:22 Inactive
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Visit the preview URL for this PR (updated for commit 85d15bf):

https://ngx-bootstrap-demo--pr6424-offcanvas-module-x2gqtwla.web.app

(expires Mon, 12 Dec 2022 11:11:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad45a8e01b9a4306733c914c8a4d7c9337cc4d07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants