Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): Thai Buddish calendar on Datepicker show wrong on le… #5715

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

tumit
Copy link
Contributor

@tumit tumit commented Mar 14, 2020

…ap year #5679

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #5715 into development will decrease coverage by 0.04%.
The diff coverage is 30.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5715      +/-   ##
===============================================
- Coverage        73.68%   73.64%   -0.05%     
===============================================
  Files              323      323              
  Lines            11664    11646      -18     
  Branches          2481     2481              
===============================================
- Hits              8595     8577      -18     
+ Misses            1966     1963       -3     
- Partials          1103     1106       +3     
Impacted Files Coverage Δ
src/chronos/format/format.ts 96.66% <ø> (-0.11%) ⬇️
src/chronos/i18n/th-be.ts 37.50% <ø> (-29.17%) ⬇️
src/datepicker/bs-datepicker-input.directive.ts 43.87% <0.00%> (+2.92%) ⬆️
src/chronos/locale/locale.class.ts 58.45% <33.33%> (-0.13%) ⬇️
src/chronos/units/year.ts 95.45% <50.00%> (-4.55%) ⬇️
...c/datepicker/bs-daterangepicker-input.directive.ts 42.73% <50.00%> (-0.82%) ⬇️
...ker/themes/bs/bs-months-calendar-view.component.ts 56.25% <0.00%> (-12.50%) ⬇️
src/chronos/i18n/pl.ts 67.56% <0.00%> (-2.71%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 74.07% <0.00%> (-1.49%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b568b9...0e75b7a. Read the comment docs.

@daniloff200
Copy link
Contributor

Well, looks like my very very strange fix (#5691) for this issue can be closed.

Gonna test it today, if everything works well, we can merge that

@daniloff200 daniloff200 merged commit 4bd2510 into valor-software:development Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants