Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add alt attribute in images #3932

Merged
merged 1 commit into from
Apr 5, 2018
Merged

feat(demo): add alt attribute in images #3932

merged 1 commit into from
Apr 5, 2018

Conversation

tarusin
Copy link
Contributor

@tarusin tarusin commented Mar 6, 2018

Closes #3930

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated demos.

Copy link
Contributor

@EvilAlexei EvilAlexei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test are failed
not latest version of env

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #3932 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3932   +/-   ##
============================================
  Coverage        72.23%   72.23%           
============================================
  Files              253      253           
  Lines             8238     8238           
  Branches          1565     1565           
============================================
  Hits              5951     5951           
  Misses            1866     1866           
  Partials           421      421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ee1f8...228c266. Read the comment docs.

@valorkin
Copy link
Member

@tarusin please resolve conflicts

@tarusin tarusin closed this Mar 29, 2018
@tarusin tarusin reopened this Mar 29, 2018
@tarusin
Copy link
Contributor Author

tarusin commented Mar 29, 2018

@valorkin @EvilAlexei
conflicts fixed

@valorkin valorkin merged commit 122a0e5 into valor-software:development Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants