Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typeahead): add accessibility attributes #582

Closed
stevenao opened this issue Jun 5, 2016 · 6 comments · Fixed by #5547
Closed

feat(typeahead): add accessibility attributes #582

stevenao opened this issue Jun 5, 2016 · 6 comments · Fixed by #5547
Labels
comp(typeahead) effort2: medium (days) enhancement WIP

Comments

@stevenao
Copy link

stevenao commented Jun 5, 2016 •
edited
Loading

Since bootstrap components will have a big user base, It is a good time to think of accessibility on all of the components. In particular, this typeahead widget is not currently accessible. When results are show, there is no indication how many results are there and how to navigate the results.

With screen reader turned on, please look at this example: http://www.bu.edu/webteam/clrux/accessibility/autocomplete/autocomplete.html.

Also, current implementation doesn't seem to allow overriding the "result" template. I have no way to adding some aria attributes to enable accessibility.
@TonD83
Copy link

TonD83 commented Jan 16, 2017

We would really benefit from an accessible typeahead component, too. Is there anything you can say about the likelihood this will be implemented a) at all and b) if so, within what timespan?
Thanks a lot, really appreciate the ng2-bootstrap components.

@valorkin valorkin added the WIP label Jan 19, 2017
@valorkin valorkin changed the title Accessible Typeahead feat(typeahead): add accessibility attributes Jan 15, 2018
@EvilAlexei EvilAlexei mentioned this issue Jan 16, 2018
Closed
66 tasks
@skesarwani
Copy link

Hi, Can it be mentioned, till when the accessibility (ARIA) attributes will be added in the typeahead so it's items can be read on the screen reader

@vd-nagarro
Copy link

@valorkin - Do we have any update on this as we need to add ARIA attributes for Accessibility with typeahead so that items can be read on the screen reader.

@gthom9
Copy link

gthom9 commented Sep 5, 2019

Hello, is there any update on when this will be added? Thanks

@JHorm
Copy link

JHorm commented Sep 26, 2019 •
edited
Loading

@valorkin It is still an issue :(. Thanks!

@samshay
Copy link
Contributor

samshay commented Nov 14, 2019

I send a pull request with modifications #5547

@samshay samshay mentioned this issue Nov 14, 2019
Merged
5 tasks
daniloff200 added a commit that referenced this issue Mar 12, 2020
@samshay @daniloff200 @dmitry-zhemchugov
feat(typeahead): improved accessibility #582 (#5547)
00b39c4 
* Add id to typeahead-container

* Add attribute aria activeDescendant

* Add aria-aria-owns and aria-aria-expanded

* Add role="option" and role="listbox"

* Add id to typeahead child

* Add aria-autocomplete

* Add role='listBox'

* Add comment

* Delete unused property

* Use rendered to set attribute id

* fix(typeahead): fix typeahead position, according to new position service changes

Co-authored-by: Samuel Renier <[email protected]>
Co-authored-by: Dmitriy Danilov <[email protected]>
Co-authored-by: dmitry-zhemchugov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(typeahead) effort2: medium (days) enhancement WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(typeahead): improved accessibility #582 samshay/ngx-bootstrap