Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): add tslint(ng2lint) Invalid type on EventEmitter. #309

Closed
ekarlso opened this issue Mar 22, 2016 · 10 comments
Closed

chore(lint): add tslint(ng2lint) Invalid type on EventEmitter. #309

ekarlso opened this issue Mar 22, 2016 · 10 comments
Assignees
Milestone

Comments

@ekarlso
Copy link

ekarlso commented Mar 22, 2016

ERROR in ./~/ng2-bootstrap/components/alert/alert.component.ts
(25,3): error TS2322: Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter'.
Type '{}' is not assignable to type 'Alert'.
Property 'type' is missing in type '{}'.

@valorkin
Copy link
Member

Angular 2 version?
If 11 close issue :)
It is broken

@ekarlso
Copy link
Author

ekarlso commented Mar 22, 2016

No I'm getting this on beta9 too, see https://gitlab.com/creator-makerspace/gatekeeper-ui for more info.

@valorkin
Copy link
Member

OK, I will pull and check what is happening

@ekarlso
Copy link
Author

ekarlso commented Mar 22, 2016

Apparantly it's a tslint error : )

Endre

2016-03-22 20:03 GMT+01:00 Dmitriy Shekhovtsov [email protected]:

OK, I will pull and check what is happening


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#309 (comment)

@valorkin
Copy link
Member

Common dude! I have digged it al over for an issue! :)
I will add ng2lint here this week

@ekarlso
Copy link
Author

ekarlso commented Mar 24, 2016

@valorkin you can try to grab my app if you can and see if you get the same error ?
https://gitlab.com/creator-makerspace/gatekeeper-ui

@valorkin valorkin changed the title Invalid type on EventEmitter. chore(lint): add tslint(ng2lint) Invalid type on EventEmitter. Mar 24, 2016
@sundriver
Copy link

+1

1 similar comment
@Slavrix
Copy link

Slavrix commented Mar 31, 2016

+1

@valorkin
Copy link
Member

valorkin commented Apr 1, 2016

should not be an issue now, because npm package contain ts files in special folder

@valorkin valorkin added this to the beta.14 milestone Apr 1, 2016
@valorkin
Copy link
Member

valorkin commented Apr 1, 2016

Failed to lint: 50 errors. (749 other errors not shown.)
trololo ...

@valorkin valorkin self-assigned this Apr 3, 2016
valorkin added a commit that referenced this issue Apr 4, 2016
fix(lint): enable tslint and codelyzer (fixes #309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants