fix(timepicker): update incrementHours logic

valor-software · Jan 15, 2020 · ac8f109 · ac8f109
1 parent 3c90957
commit ac8f109
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/timepicker/timepicker-controls.util.ts b/src/timepicker/timepicker-controls.util.ts
@@ -119,6 +119,7 @@ export function timepickerControls(
   value: Date,
   state: TimepickerComponentState
 ): TimepickerControls {
+  const hoursPerDay = 24;
   const hoursPerDayHalf = 12;
   const { min, max, hourStep, minuteStep, secondsStep, showSeconds } = state;
   const res: TimepickerControls = {
@@ -140,7 +141,7 @@ export function timepickerControls(
   // compare dates
   if (max) {
     const _newHour = changeTime(value, { hour: hourStep });
-    res.canIncrementHours = max > _newHour;
+    res.canIncrementHours = max > _newHour && (value.getHours() + hourStep) < hoursPerDay;
 
     if (!res.canIncrementHours) {
       const _newMinutes = changeTime(value, { minute: minuteStep });

diff --git a/src/timepicker/timepicker.utils.ts b/src/timepicker/timepicker.utils.ts
@@ -101,10 +101,6 @@ export function changeTime(value: Date, diff: Time): Date {
     hour = (hour + toNumber(diff.hour)) % hoursPerDay;
     if (hour < 0) {
       hour += hoursPerDay;
-    } else if (hour === 0) {
-      hour = 23;
-      minutes = 59;
-      seconds = 59;
     }
   }