Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path separator for generated YAML on Windows (fixes #68) #69

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

JuhaKiili
Copy link
Contributor

If you generate YAML on a Windows machine, you still want the path separator to be POSIX.

fixes #68

@JuhaKiili JuhaKiili force-pushed the windows-yaml branch 2 times, most recently from 1d0ae06 to 66dff74 Compare October 8, 2021 09:57
@JuhaKiili JuhaKiili requested a review from ruksi October 8, 2021 10:00
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a suggestion to improve the test and suggestion of extending CI testing surface

tests/test_yaml.py Outdated Show resolved Hide resolved
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint

Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ruksi ruksi merged commit 53e635e into master Oct 15, 2021
@ruksi ruksi deleted the windows-yaml branch October 15, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slash handling when using Windows
2 participants