Support notebooks in YAML generator (fixes #61) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruksi
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notebook source file support for the YAML generator that the Valohai CLI is calling.
You can create YAML step from Python file today:
Now with valohai-utils support for notebooks, you can do the same with notebooks:
This will generate the YAML step that runs a notebook using Papermill. The notebook is assumed to use valohai-utils to define parameters and inputs.
Note: This PR has some copy-pasta code from Jupyhai, related to parsing source code from notebooks. We don't want valohai-utils to be dependent on Jupyhai, but Jupyhai is already dependent on valohai-utils. Once this PR is merged in, we should DRY at the Jupyhai side if possible.