Add support for overriding inputs via CLI args #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
reviewed
Feb 23, 2021
valohai/utils.py
Outdated
| if "://" not in value and os.path.isfile(value): # The string is a local path | ||
| files.append(FileInfo(name=os.path.basename(value), uri=None, path=value, size=None, checksums=None)) | ||
| else: # The string is an URI | ||
| files.append(FileInfo(name=FileInfo.uri_to_filename(value), uri=value, path=None, size=None, checksums=None)) |
There was a problem hiding this comment.
This is the reason uri_to_filename feels like it should be a free function...
akx
requested changes
Feb 23, 2021
valohai/utils.py
Outdated
Comment on lines
52
to
53
| inputs = {k: v for k, v in vars(args).items() if k in names} | ||
| for name, values in inputs.items(): |
There was a problem hiding this comment.
Maybe simpler put as
Suggested change
| inputs = {k: v for k, v in vars(args).items() if k in names} | |
| for name, values in inputs.items(): | |
| for name, values in vars(args).items(): | |
| if name not in names: | |
| continue |
valohai/utils.py
Outdated
Comment on lines
78
to
79
| parameters = {k: v for k, v in vars(args).items() if k in names} | ||
| for name, value in parameters.items(): |
There was a problem hiding this comment.
Suggested change
| parameters = {k: v for k, v in vars(args).items() if k in names} | |
| for name, value in parameters.items(): | |
| for name, value in vars(args).items(): | |
| if name not in names: | |
| continue |
akx
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can locally override only the parameters through the CLI currently. For example:
python train.py --lr=0.001In Valohai CLI & UI you can also override inputs. We need to have that from valohai-utils too. For example:
python train.py --images=/tmp/lol/*.pngThis PR makes that possible.