Ignore default value for inputs if it's local file path #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase this PR once #123 is merged to |
dangquangdon
force-pushed
the
dangquangdon-ignore-input-value-point-to-local-path
branch
from
e2d83b9 to
8d2063e
Compare
akx
requested review from
akx,
a team,
hylje and
ruksi
and removed request for
a team
akx
reviewed
Feb 7, 2024
ruksi
reviewed
Feb 7, 2024
When generating/updating config to valohai.yaml, we will ignore the value of inputs if it's pointing to a local file path
dangquangdon
force-pushed
the
dangquangdon-ignore-input-value-point-to-local-path
branch
from
8d2063e to
8b434f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #49
When generating/updating config to
valohai.yaml, we will ignore the value of inputs if it's pointing to a local file path