Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hard-require tqdm for downloads #102

Merged
merged 2 commits into from
May 23, 2023
Merged

Don't hard-require tqdm for downloads #102

merged 2 commits into from
May 23, 2023

Conversation

akx
Copy link
Member

@akx akx commented Oct 31, 2022 •
edited
Loading

We don't actually need tqdm as a dependency for valohai-utils, it's just for fancy progress bars.

(This PR became simpler now that we're targeting Python 3.7 which has nullcontext.)

@akx akx force-pushed the drop-tqdm-dep branch 2 times, most recently from f50901f to 52fd577 Compare February 3, 2023 15:36
@akx akx added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 3, 2023
@akx akx force-pushed the drop-tqdm-dep branch 3 times, most recently from fc418ed to 03c6232 Compare May 23, 2023 11:53
@akx akx force-pushed the drop-tqdm-dep branch from 03c6232 to e33c3a9 Compare May 23, 2023 11:53
@akx akx marked this pull request as ready for review May 23, 2023 12:03
@akx akx requested review from a team, ruksi and memona008 and removed request for a team May 23, 2023 12:03
@akx akx mentioned this pull request May 23, 2023
Merged
ruksi
ruksi approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy download bars are now optional, lgtm

@ruksi ruksi merged commit 7994edb into master May 23, 2023
@ruksi ruksi deleted the drop-tqdm-dep branch May 23, 2023 13:10
akx added a commit that referenced this pull request May 29, 2023
@akx
Fix a tqdmlessness bug from #102
9be3897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruksi ruksi ruksi approved these changes

@memona008 memona008 Awaiting requested review from memona008 memona008 was automatically assigned from valohai/dev

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @ruksi