RDMA builtin support #1209
Open
RDMA builtin support #1209
+259
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, special config 'bind' is used for socket and TLS, however multiple addresses handling is also workable for RDMA(QUIC in the future). Abstract bind option as helper functions to apply more connection types. rewriteConfigBindOption is a local function, declare it as 'static' function. Signed-off-by: zhenwei pi <[email protected]>
Socket family use close() syscall to close listener, however RDMA has another style. Use an abstract function handler instead of hard code syscall style. Signed-off-by: zhenwei pi <[email protected]>
Move 4 parameters from valkey-rdma.so to valkey-server, keep RDMA listener similar to TCP/TLS. Also prepare to build Valkey Over RDMA into builtin. Signed-off-by: zhenwei pi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1209 +/- ##
============================================
- Coverage 70.72% 70.52% -0.20%
============================================
Files 114 115 +1
Lines 63090 63152 +62
============================================
- Hits 44621 44540 -81
- Misses 18469 18612 +143
|
Support RDMA builtin and module together. To build a builtin version: $ make BUILD_RDMA=yes Signed-off-by: zhenwei pi <[email protected]>
pizhenwei
force-pushed
the
rdma-build-yes
branch
from
35884e2
to
047c7ec
Compare
|
@valkey-io/core-team Please approve. This adds It is a step towards official (non-experimantal) RDMA support. I already merged the RDMA fork-safety here: #1244. It makes sure the server doesn't crash if we try to talk to an RDMA client from a forked child process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are several patches in this PR:
bindoption is a special config,socketandtlsare using the same one. However RDMA uses the similar style but different one. Use a bit abstract work to make it flexible for bothsocketandRDMA. Even for QUIC in the future.--rdma-bindand--rdma-portstyle instead of module parameters.make BUILD_RDMA=yes. module style is still kept for now. Once module style is decided to drop, I volunteer to do it for TLS and RDMA together.Each patch has independent functionality, also been tested by CI and local commands, so request no-squash merge for this PR.