Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Remove 'posting in the mailing list' in contributing.md #1174

Merged

Conversation

Shivshankar-Reddy
Copy link
Contributor

With referece of below slack discussion: I have created this PR to remove the statemnet about mailing list and updated the file.

Mateusz Warzynski
Yesterday at 7:44 AM
Hello everyone! It's nice to meet you.
I've discussed possible observability enhancements in Valkey with
@Irfan Ahmad
, which lead to drafting the design proposal. I believe the process of contribution is outlined here.
Start by posting in the mailing list and creating an issue at GitHub with the description of, exactly, what you want to accomplish and why.
I've published a draft proposal for observability enhancements in Valkey: #1167. Does this message satisfy the 'posting in the mailing list'?

Viktor Söderqvist (Ericsson)
Yesterday at 8:00 AM
'posting in the mailing list'
We've never had a mailing list. 😂 This must be left from redis times. We need to delete this sentence.
Posting an issue is a great first step. Thanks!

Signed-off-by: Shivshankar-Reddy <[email protected]>
@Shivshankar-Reddy Shivshankar-Reddy changed the title Remove 'posting in the mailing list' in contributing.md [Minor] Remove 'posting in the mailing list' in contributing.md Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.63%. Comparing base (b0f23df) to head (aba8585).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1174      +/-   ##
============================================
- Coverage     70.64%   70.63%   -0.01%     
============================================
  Files           114      114              
  Lines         61740    61740              
============================================
- Hits          43615    43609       -6     
- Misses        18125    18131       +6     

see 13 files with indirect coverage changes

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zuiderkwast zuiderkwast merged commit b927fb0 into valkey-io:unstable Oct 15, 2024
46 checks passed
eifrah-aws pushed a commit to eifrah-aws/valkey that referenced this pull request Oct 20, 2024
Remove reference to "the mailing list". We don't have a mailing list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants