Fix module / script call CLUSTER SLOTS / SHARDS fake client check crash #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. Fixes valkey-io#1054. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
requested review from
zuiderkwast and
PingXie
and removed request for
zuiderkwast
enjoy-binbin
added
the
run-extra-tests
Signed-off-by: Binbin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1063 +/- ##
============================================
+ Coverage 70.46% 70.62% +0.15%
============================================
Files 114 114
Lines 61688 61694 +6
============================================
+ Hits 43467 43569 +102
+ Misses 18221 18125 -96
|
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
PingXie
reviewed
Sep 23, 2024
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
changed the title
zuiderkwast
approved these changes
Sep 24, 2024
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
added
the
release-notes
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Sep 30, 2024
…sh (valkey-io#1063) The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. This also affects scripts. If they are called in the script, the server will crash. Injecting commands into AOF will also cause startup failure. Fixes valkey-io#1054. Signed-off-by: Binbin <[email protected]>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
…sh (valkey-io#1063) The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. This also affects scripts. If they are called in the script, the server will crash. Injecting commands into AOF will also cause startup failure. Fixes valkey-io#1054. Signed-off-by: Binbin <[email protected]> Signed-off-by: naglera <[email protected]>
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Oct 21, 2024
The fake client flag was introduced in valkey-io#1063, we want this to replace all !conn fake client checks. Signed-off-by: Binbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is VM_Call will use a fake client without connection,
so we also need to check if c->conn is NULL.
This also affects scripts. If they are called in the script, the
server will crash. Injecting commands into AOF will also cause
startup failure.
Fixes #1054.