Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redis-cluster-py link #99

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix redis-cluster-py link #99

merged 1 commit into from
Sep 24, 2024

Conversation

amirreza8002
Copy link
Contributor

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

I'm not sure if you want to keep the link to this package, from what i understand a lot of things have changed, for example atomic transactions are now possible (at least that's what i know).
so let me know what you decide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (b060e38) to head (b7991b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   75.18%   75.17%   -0.01%     
==========================================
  Files         132      132              
  Lines       34480    34480              
==========================================
- Hits        25925    25922       -3     
- Misses       8555     8558       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/clustering.rst Outdated Show resolved Hide resolved
Signed-off-by: amirreza <[email protected]>
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mkmkme mkmkme merged commit ca19329 into valkey-io:main Sep 24, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants