Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop compose format and commands v1, use supported v2+ #105

Merged
merged 1 commit into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Here's how to get started with your code contribution:
c. pip install -r dev_requirements.txt
c. pip install -r requirements.txt

4. If you need a development environment, run `invoke devenv`. Note: this relies on docker-compose to build environments, and assumes that you have a version supporting [docker profiles](https://docs.docker.com/compose/profiles/).
4. If you need a development environment, run `invoke devenv`. Note: this relies on docker compose to build environments, and assumes that you have a version supporting [docker profiles](https://docs.docker.com/compose/profiles/).
5. While developing, make sure the tests pass by running `invoke tests`
6. If you like the change and think the project could use it, send a
pull request
Expand Down
2 changes: 0 additions & 2 deletions docker-compose.yml → compose.yaml
mkmkme marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---

version: "3.8"

services:

valkey:
Expand Down
4 changes: 2 additions & 2 deletions docs/examples/opentelemetry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ pip install -r requirements.txt
**Step 4**. Start the services using Docker and make sure Uptrace is running:

```shell
docker-compose up -d
docker-compose logs uptrace
docker compose up -d
docker compose logs uptrace
```

**Step 5**. Run the Valkey client example and follow the link from the CLI to view the trace:
Expand Down
mkmkme marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: "3"

services:
clickhouse:
image: clickhouse/clickhouse-server:22.7
Expand Down
Loading