Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort methods ACL DELUSER and ACL DRYRUN by alphabetically, checked doc #103

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ArtemIsmagilov
Copy link
Contributor

@ArtemIsmagilov ArtemIsmagilov commented Sep 29, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

I have sorted the two methods alphabetically as stated in the documentation. This may not have an effect, but it is more convenient to view the code as well as the documentation, namely in alphabetical order.

@ArtemIsmagilov ArtemIsmagilov changed the title sort methods ACL DELUSER and ACL DRYRUN by alphabetically, checke… sort methods ACL DELUSER and ACL DRYRUN by alphabetically, checked doc Sep 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (df59e4c) to head (dee949e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   75.18%   75.17%   -0.01%     
==========================================
  Files         132      132              
  Lines       34480    34480              
==========================================
- Hits        25925    25922       -3     
- Misses       8555     8558       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArtemIsmagilov
Copy link
Contributor Author

@mkmkme , why not?

@mkmkme
Copy link
Collaborator

mkmkme commented Oct 7, 2024

Sorry, I didn't have time to approve this.
I also pushed the "update branch" button without thinking it would create an ugly "merge from main" commit. Could you rebase your branch on the top of current state of main please?

The change is cosmetic and looks good to me.

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mkmkme mkmkme merged commit e9b7ba3 into valkey-io:main Oct 8, 2024
84 checks passed
@ArtemIsmagilov ArtemIsmagilov deleted the alphabetical-methods-by-doc branch October 8, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants