Python: adds ZSCORE command #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Feb 1, 2024
| member (str): The member whose score is to be retrieved. | ||
|
|
||
| Returns: | ||
| Optional[float]: The score of the member, or None if the member does not exist in the sorted set. |
There was a problem hiding this comment.
The description lacks that option of returning null if the key does not exist, please stick to the documentation in redis as I might have missed that
barshaul
reviewed
Feb 1, 2024
| member (str): The member whose score is to be retrieved. | ||
|
|
||
| Commands response: | ||
| Optional[float]: The score of the member, or None if the member does not exist in the sorted set. |
barshaul
reviewed
Feb 1, 2024
| key = get_random_string(10) | ||
| members_scores = {"one": 1, "two": 2, "three": 3} | ||
| assert await redis_client.zadd(key, members_scores=members_scores) == 3 | ||
| assert await redis_client.zscore(key, "one") == 1 |
There was a problem hiding this comment.
please test it with a float, not an int
barshaul
reviewed
Feb 1, 2024
shohamazon
force-pushed
the
python/zscore
branch
4 times, most recently
from
4300e43
to
495c8f1
Compare
shohamazon
force-pushed
the
python/zscore
branch
from
495c8f1
to
5c18446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.