Node: add FT.CREATE command
#2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
node/acarbo_add_ft_create
branch
from
92a3b10
to
6fdadc4
Compare
acarbonetto
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
node/tests/ServerModules.test.ts
Outdated
| expect( | ||
| await GlideFt.create(client, uuidv4(), [vectorField_3], { | ||
| dataType: "HASH", | ||
| prefixes: ["docs:"], |
There was a problem hiding this comment.
When you'll test search or aggregate, use {} in prefix to ensure same slot
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
tjzhang-BQ
reviewed
Oct 22, 2024
| @@ -32,7 +32,8 @@ | |||
| "compile-protobuf-files": "cd src && pbjs -t static-module -o ProtobufMessage.js ../../glide-core/src/protobuf/*.proto && pbts -o ProtobufMessage.d.ts ProtobufMessage.js", | |||
| "fix-protobuf-file": "replace 'this\\.encode\\(message, writer\\)\\.ldelim' 'this.encode(message, writer && writer.len ? writer.fork() : writer).ldelim' src/ProtobufMessage.js", | |||
| "test": "npm run build-test-utils && jest --verbose --runInBand --testPathIgnorePatterns='ServerModules'", | |||
| "test-modules": "npm run build-test-utils && jest --verbose --runInBand --testPathPattern='ServerModules'", | |||
| "test-minimum": "npm run build-test-utils && jest --verbose --runInBand --testNamePattern='^(.(?!(GlideJson|GlideFt|pubsub|kill)))*$'", | |||
There was a problem hiding this comment.
small nit: with a negative lookahead removing the modules/pubsub/kill tests, would it be better to name this something like base rather than minimum?
There was a problem hiding this comment.
I don't like base. I originally called it 'fast'. The idea is that it skips the long tests, and could maybe be used for doing a sanity check on the client.
tjzhang-BQ
approved these changes
Oct 22, 2024
Yury-Fridlyand
approved these changes
Oct 22, 2024
node/tests/ServerModules.test.ts
Outdated
| @@ -280,3 +279,190 @@ describe("GlideJson", () => { | |||
| }, | |||
| ); | |||
| }); | |||
|
|
|||
| describe("GlideFt", () => { | |||
| let cluster: ValkeyCluster; | |||
There was a problem hiding this comment.
I think you can reuse this instead of copy-pasting. Either move common code to a helper function or merge top-level describe blocks (you can define nested blocks inside).
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
cyip10
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add FT.CREATE command for Node Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Add FT.CREATE command for Node Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
This was referenced Oct 25, 2024
BoazBD
pushed a commit
to BoazBD/valkey-glide
that referenced
this pull request
Oct 27, 2024
* Add FT.CREATE command for Node Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: BoazBD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #738
Checklist
Before submitting the PR make sure the following are checked: