Java: JSON.OBJLEN and JSON.OBJKEYS.
#2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
acarbonetto
approved these changes
Oct 22, 2024
java/client/src/main/java/glide/api/commands/servermodules/Json.java
Outdated
Show resolved
Hide resolved
| * assert Arrays.equals((Object[]) res, new Object[][] { { "a", "b", "c" } }); // key names as a nested list for objects matching the JSONPath `$.b`. | ||
| * }</pre> | ||
| */ | ||
| public static CompletableFuture<Object[]> objkeys( |
There was a problem hiding this comment.
objkeys returns an array is all cases? well at least one of the commands acts decently.
There was a problem hiding this comment.
Object[][] for JSONPath and Object[] for legacy path. So common denominator is Object[].
| assertEquals(2L, res); | ||
| res = Json.objlen(client, gs(key)).get(); | ||
| assertEquals(2L, res); | ||
| } |
There was a problem hiding this comment.
should we test when the path doesn't exist, or the path is not an array, or the key is not JSON?
There was a problem hiding this comment.
There was a problem hiding this comment.
Maybe. I don't want to start testing module instead of client.
| res = Json.objkeys(client, key).get(); | ||
| assertArrayEquals(new Object[] {"a", "b"}, res); | ||
| res = Json.objkeys(client, gs(key)).get(); | ||
| assertArrayEquals(new Object[] {gs("a"), gs("b")}, res); |
There was a problem hiding this comment.
should we test when the path doesn't exist, or the path is not an array, or the key is not JSON?
yipin-chen
approved these changes
Oct 22, 2024
…alkey-449 Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Oct 25, 2024
* `JSON.OBJLEN` and `JSON.OBJKEYS`. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
BoazBD
pushed a commit
to BoazBD/valkey-glide
that referenced
this pull request
Oct 27, 2024
* `JSON.OBJLEN` and `JSON.OBJKEYS`. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: BoazBD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#2430
Checklist
Before submitting the PR make sure the following are checked: