Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: add JSON.ARRAPPEND command #2489

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Java: add JSON.ARRAPPEND command #2489

merged 3 commits into from
Oct 21, 2024

Conversation

yipin-chen
Copy link
Collaborator

@yipin-chen yipin-chen commented Oct 21, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2430

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@yipin-chen
Updated CHANGELOG
b3ac16a 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen yipin-chen added the java issues and fixes related to the java client label Oct 21, 2024
@yipin-chen yipin-chen marked this pull request as ready for review October 21, 2024 20:27
@yipin-chen yipin-chen requested a review from a team as a code owner October 21, 2024 20:27
jonathanl-bq
jonathanl-bq approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Yury's comments and I think it's fine.

java/integTest/src/test/java/glide/modules/JsonTests.java Show resolved Hide resolved
@yipin-chen
Addressed review comments
8dd0557 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen yipin-chen merged commit 76f68a6 into release-1.2 Oct 21, 2024
14 checks passed
@yipin-chen yipin-chen deleted the java/yipin-valkey-441 branch October 21, 2024 22:39
BoazBD pushed a commit to BoazBD/valkey-glide that referenced this pull request Oct 22, 2024
@yipin-chen @BoazBD
Java: add JSON.ARRAPPEND command (valkey-io#2489)
6135927 
* Java: add JSON.ARRAPPEND command
---------
Signed-off-by: Yi-Pin Chen <[email protected]>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@yipin-chen @Muhammad-awawdi-amazon
Java: add JSON.ARRAPPEND command (valkey-io#2489)
7d351f7 
* Java: add JSON.ARRAPPEND command
---------
Signed-off-by: Yi-Pin Chen <[email protected]>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@yipin-chen @Muhammad-awawdi-amazon
Java: add JSON.ARRAPPEND command (valkey-io#2489)
8a59c67 
* Java: add JSON.ARRAPPEND command
---------
Signed-off-by: Yi-Pin Chen <[email protected]>
cyip10 pushed a commit that referenced this pull request Oct 23, 2024
@yipin-chen @cyip10
Java: add JSON.ARRAPPEND command (#2489)
305a99b 
* Java: add JSON.ARRAPPEND command
---------
Signed-off-by: Yi-Pin Chen <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 24, 2024
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanl-bq jonathanl-bq jonathanl-bq approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@tjzhang-BQ tjzhang-BQ tjzhang-BQ approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yipin-chen @jonathanl-bq @Yury-Fridlyand @tjzhang-BQ