Python: Add `FT.SEARCH` command #2470

prateek-kumar-improving · 2024-10-17T01:39:31Z

Issue link

This Pull Request is linked to issue (URL): #2429

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

Signed-off-by: Prateek Kumar <[email protected]>

python/python/tests/tests_server_modules/search/test_ft_search.py

Signed-off-by: Prateek Kumar <[email protected]>

python/python/glide/async_commands/server_modules/ft.py

python/python/tests/tests_server_modules/search/test_ft_search.py

Signed-off-by: prateek-kumar-improving <[email protected]>

Signed-off-by: Prateek Kumar <[email protected]>

python/python/glide/async_commands/server_modules/ft.py

python/python/glide/async_commands/server_modules/ft_options/ft_search_options.py

python/python/tests/tests_server_modules/search/test_ft_search.py

Yury-Fridlyand · 2024-10-17T23:31:25Z

Add changelog please

Signed-off-by: Prateek Kumar <[email protected]>

python/python/glide/async_commands/server_modules/ft.py

python/python/glide/async_commands/server_modules/ft_options/ft_constants.py

Signed-off-by: Prateek Kumar <[email protected]>

* Python: Add FT.SEARCH command --------- Signed-off-by: Prateek Kumar <[email protected]> Signed-off-by: prateek-kumar-improving <[email protected]>

Python: Add FT.SEARCH command

b571a7f

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving requested a review from a team as a code owner October 17, 2024 01:39

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 17, 2024 01:39 — with GitHub Actions Error

prateek-kumar-improving requested review from acarbonetto, Yury-Fridlyand and shohamazon October 17, 2024 01:42

prateek-kumar-improving added the python label Oct 17, 2024

prateek-kumar-improving mentioned this pull request Oct 17, 2024

Python: VSS commands support #2429

Open

14 tasks

prateek-kumar-improving commented Oct 17, 2024

View reviewed changes

python/python/tests/tests_server_modules/search/test_ft_search.py Show resolved Hide resolved

prateek-kumar-improving changed the title ~~Python: Add FT.SEARCH command~~ Python: Add FT.SEARCH command Oct 17, 2024

Python FT.SEARCH - rust file removed

dc8d2c4

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving requested a deployment to AWS_ACTIONS October 17, 2024 17:40 — with GitHub Actions Waiting

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 17, 2024 17:40 — with GitHub Actions Error

Python FT.SEARCH Rust file removed

560d165

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving temporarily deployed to AWS_ACTIONS October 17, 2024 17:41 — with GitHub Actions Inactive

acarbonetto reviewed Oct 17, 2024

View reviewed changes

Merge branch 'release-1.2' into python-ft-search-command

fcec549

Signed-off-by: prateek-kumar-improving <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 17, 2024 21:13 — with GitHub Actions Error

Python FT.SEARCH review comments addressed

e937736

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 17, 2024 21:15 — with GitHub Actions Error

Review comments fixed

67680e9

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 17, 2024 21:18 — with GitHub Actions Error

Merge branch 'release-1.2' into python-ft-search-command

2c67c84

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 17, 2024 22:52 — with GitHub Actions Error

Yury-Fridlyand reviewed Oct 17, 2024

View reviewed changes

Python: Review comments addressed

4d334f1

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 18, 2024 00:05 — with GitHub Actions Error

CHANGELOG.md updated

327faea

Signed-off-by: Prateek Kumar <[email protected]>

Python FT.SEARCH fix review comments

c137a27

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 18, 2024 23:21 — with GitHub Actions Error

Python FT.SEARCH utils updated

c666d07

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving temporarily deployed to AWS_ACTIONS October 18, 2024 23:57 — with GitHub Actions Inactive

Yury-Fridlyand approved these changes Oct 19, 2024

View reviewed changes

Merge branch 'release-1.2' into python-ft-search-command

8b9c356

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 20, 2024 09:09 — with GitHub Actions Error

Merge branch 'release-1.2' into python-ft-search-command

79dbc48

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 21, 2024 04:52 — with GitHub Actions Error

Merge branch 'release-1.2' into python-ft-search-command

b1714a4

prateek-kumar-improving temporarily deployed to AWS_ACTIONS October 21, 2024 16:49 — with GitHub Actions Inactive

prateek-kumar-improving temporarily deployed to AWS_ACTIONS October 21, 2024 17:38 — with GitHub Actions Inactive

Merge branch 'release-1.2' into python-ft-search-command

13721e7

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 22, 2024 00:42 — with GitHub Actions Error

Python FT.SEARCH delete index after ft.search test

b06c1fe

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 22, 2024 00:50 — with GitHub Actions Error

acarbonetto reviewed Oct 22, 2024

View reviewed changes

python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved

acarbonetto approved these changes Oct 22, 2024

View reviewed changes

python/python/glide/async_commands/server_modules/ft_options/ft_constants.py Outdated Show resolved Hide resolved

Python: update documentation

ca5f9f1

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 22, 2024 01:34 — with GitHub Actions Error

Python FT.SEARCH fix documenation

bb1b65d

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 22, 2024 01:36 — with GitHub Actions Error

Python FT.SEARCH fix documentation

ce312a5

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving temporarily deployed to AWS_ACTIONS October 22, 2024 01:41 — with GitHub Actions Inactive

acarbonetto merged commit 9073eb0 into release-1.2 Oct 22, 2024
16 checks passed

acarbonetto deleted the python-ft-search-command branch October 22, 2024 01:59

cyip10 pushed a commit that referenced this pull request Oct 23, 2024

Python: Add FT.SEARCH command (#2470)

5a4944e

* Python: Add FT.SEARCH command --------- Signed-off-by: Prateek Kumar <[email protected]> Signed-off-by: prateek-kumar-improving <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python: Add `FT.SEARCH` command #2470

Python: Add `FT.SEARCH` command #2470

prateek-kumar-improving commented Oct 17, 2024 •

edited

Loading

Yury-Fridlyand commented Oct 17, 2024

Python: Add FT.SEARCH command #2470

Python: Add FT.SEARCH command #2470

Conversation

prateek-kumar-improving commented Oct 17, 2024 • edited Loading

Issue link

Checklist

Yury-Fridlyand commented Oct 17, 2024

Python: Add `FT.SEARCH` command #2470

Python: Add `FT.SEARCH` command #2470

prateek-kumar-improving commented Oct 17, 2024 •

edited

Loading