Java: Allow to run modules CI on demand. #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
added
java
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Oct 9, 2024
acarbonetto
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
please add changelog as a "Operational Enhancements"
https://github.com/valkey-io/valkey-glide/blob/main/CHANGELOG.md?plain=1#L7
acarbonetto
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Note: CI skips Module Tests for this PR
https://github.com/valkey-io/valkey-glide/actions/runs/11262629814/job/31318749803?pr=2416
Need to test that a manual dispatch doesn't kick it off from a fork...
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
shohamazon
approved these changes
Oct 13, 2024
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
* Run modules CI on demand. Signed-off-by: Yury-Fridlyand <[email protected]>
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
* Run modules CI on demand. Signed-off-by: Yury-Fridlyand <[email protected]>
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 22, 2024
* Run modules CI on demand. Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #2404 - allow a developer to run modules CI without creating a PR