Node: Fixed missing exports #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
approved these changes
Sep 16, 2024
|
Add export for |
shohamazon
approved these changes
Sep 17, 2024
acarbonetto
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Please also fix the examples application for node:
https://github.com/valkey-io/valkey-glide/blob/main/examples/node/index.ts#L52
to:
const pong = await client.customCommand(["PING"], { route: "randomNode" });
yipin-chen
changed the title
GumpacG
approved these changes
Sep 17, 2024
acarbonetto
requested changes
Sep 18, 2024
acarbonetto
reviewed
Sep 18, 2024
|
I just found that |
Yury-Fridlyand
approved these changes
Sep 18, 2024
|
according to https://github.com/Bit-Quill/valkey-glide/actions/runs/10929789563/job/30341270532 |
acarbonetto
approved these changes
Sep 19, 2024
acarbonetto
reviewed
Sep 19, 2024
yipin-chen
changed the title
prateek-kumar-improving
approved these changes
Sep 19, 2024
Signed-off-by: Yi-Pin Chen <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
node/yipin-fix-Script-export
branch
from
cd53666
to
c1d7ac9
Compare
shohamazon
pushed a commit
to shohamazon/glide-for-redis
that referenced
this pull request
Sep 23, 2024
Node: include missing exports in the npm release Signed-off-by: Yi-Pin Chen <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing exports:
ScriptObjectTypeClusterScanCursorBaseClientConfigurationGlideClusterClientConfigurationLevelOptionsThis PR will resolve issue #2307