Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding node lpos #2185

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Adding node lpos #2185

merged 3 commits into from
Aug 22, 2024

Conversation

prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Aug 21, 2024

Command documentation: https://valkey.io/commands/lpos/
Added binary support for lpos command.
Files updated: BaseClient.ts, Transaction.ts and SharedTests.ts

@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner August 21, 2024 23:08
@prateek-kumar-improving prateek-kumar-improving force-pushed the node-prateek-lpos branch 3 times, most recently from 2b0ff08 to 4629e2e Compare August 22, 2024 16:56
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
Signed-off-by: Prateek Kumar <[email protected]>
@acarbonetto acarbonetto merged commit 860a646 into valkey-io:main Aug 22, 2024
9 checks passed
@acarbonetto acarbonetto deleted the node-prateek-lpos branch August 22, 2024 21:05
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Aug 25, 2024
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants