Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add binary api for bitmap commands #2178

Merged

Conversation

acarbonetto
Copy link
Collaborator

@acarbonetto acarbonetto commented Aug 21, 2024

commands updated:

  • bitop
  • getbit
  • setbit
  • bitpos/bitposInterval
  • bitfield
  • bitfield_ro
  • bitcount

@acarbonetto acarbonetto requested a review from a team as a code owner August 21, 2024 00:55
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

node/src/Commands.ts Show resolved Hide resolved
node/src/Commands.ts Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the node/acarbo_binary_bitfield_commands branch from 3924035 to 14ca50a Compare August 22, 2024 22:24
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the node/acarbo_binary_bitfield_commands branch from 557acac to 04bbbd7 Compare August 22, 2024 22:25
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Yury-Fridlyand Yury-Fridlyand merged commit 3131719 into valkey-io:main Aug 23, 2024
9 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/acarbo_binary_bitfield_commands branch August 23, 2024 00:46
prateek-kumar-improving pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 23, 2024
* Node: Add binary api for bitmap commands

Signed-off-by: Andrew Carbonetto <[email protected]>
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Aug 25, 2024
* Node: Add binary api for bitmap commands

Signed-off-by: Andrew Carbonetto <[email protected]>
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Aug 25, 2024
* Node: Add binary api for bitmap commands

Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants