Node: Add command XGROUP SETID #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzhang-BQ
force-pushed
the
node/integ-tjz-VALKEY-42-xgroup-setid
branch
2 times, most recently
from
066d58c
to
27de138
Compare
GumpacG
reviewed
Aug 20, 2024
GumpacG
approved these changes
Aug 20, 2024
acarbonetto
approved these changes
Aug 20, 2024
added 5 commits
August 20, 2024 10:32
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
tjzhang-BQ
force-pushed
the
node/integ-tjz-VALKEY-42-xgroup-setid
branch
from
438f203
to
7fe53ef
Compare
Yury-Fridlyand
approved these changes
Aug 20, 2024
| ): Promise<string> { | ||
| return this.createWritePromise( | ||
| createXGroupSetid(key, groupName, id, entriesRead), | ||
| ); |
There was a problem hiding this comment.
add string decoder there
Signed-off-by: TJ Zhang <[email protected]>
| return this.createWritePromise( | ||
| createXGroupSetid(key, groupName, id, entriesRead), | ||
| { | ||
| decoder: decoder, |
There was a problem hiding this comment.
String decoder should be hardcoded there, because command returns OK. No need to add decoder arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.