Node: Add FUNCTION KILL command
#2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
…-fkill-valkey-95 Signed-off-by: Yury-Fridlyand <[email protected]>
yipin-chen
approved these changes
Aug 12, 2024
GumpacG
approved these changes
Aug 13, 2024
Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Aug 13, 2024
| }, | ||
| ); | ||
|
|
||
| describe.each([ProtocolVersion.RESP2, ProtocolVersion.RESP3])( |
There was a problem hiding this comment.
wait, why are we removing this?
There was a problem hiding this comment.
We were closing and re-opening describe blocks, so I just merged them.
Instead
describe([RESP2, RESP3] ... it(<test 1>))
describe([RESP2, RESP3] ... it(<test 2>))
I made
describe([RESP2, RESP3] ... it(<test 1>) it(<test 2>))
acarbonetto
approved these changes
Aug 13, 2024
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 14, 2024
* Add `FUNCTION KILL` command. Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: lior sventitzky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No transaction impl, because when server is busy by a function/script, it does not accept transactions.
IT for this commands take ~80 sec