Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: BLMOVE #2027

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Node: BLMOVE #2027

merged 15 commits into from
Jul 30, 2024

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Jul 26, 2024

Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 cyip10 added the node label Jul 26, 2024
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 cyip10 marked this pull request as ready for review July 27, 2024 00:22
@cyip10 cyip10 requested a review from a team as a code owner July 27, 2024 00:22
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a cross slot test

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
@Yury-Fridlyand
Copy link
Collaborator

Please rerun linter

Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 cyip10 merged commit 59aef04 into valkey-io:main Jul 30, 2024
8 checks passed
@cyip10 cyip10 deleted the node/integ_cyip10_blmove branch July 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants