Node: fix ZADD bug #1995
Merged
Node: fix ZADD bug #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
force-pushed
the
node/integ_guiang_zadd_bug
branch
from
b140b50
to
a44386a
Compare
Yury-Fridlyand
approved these changes
Jul 22, 2024
aaron-congo
approved these changes
Jul 22, 2024
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
force-pushed
the
node/integ_guiang_zadd_bug
branch
from
2ee5828
to
413c830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug in the ZADD implementation does not allow for users to call
zaddwith only thechangedparameter. This PR will allow forzadd("key", { one: 1, two: 2 }, { changed: true });to be supported.