Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add GEOADD #1980

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

tjzhang-BQ
Copy link
Collaborator

No description provided.

@tjzhang-BQ tjzhang-BQ force-pushed the node/integ_tjz_geoadd branch 7 times, most recently from bad84c5 to 328ff7a Compare July 19, 2024 01:47
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review July 19, 2024 03:13
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner July 19, 2024 03:13
@tjzhang-BQ tjzhang-BQ changed the title Node: Add GEOADD (WIP) Node: Add GEOADD Jul 19, 2024
node/src/command-options/ConditionalChange.ts Outdated Show resolved Hide resolved
node/src/command-options/ConditionalChange.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeoAddOptions.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeoAddOptions.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeoAddOptions.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeospatialData.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeospatialData.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address Yury's comments and the rest looks okay to me.

Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeoAddOptions.ts Outdated Show resolved Hide resolved
node/src/command-options/geospatial/GeospatialData.ts Outdated Show resolved Hide resolved
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ_tjz_geoadd branch 6 times, most recently from 04dadd3 to 00b9933 Compare July 19, 2024 18:56
Signed-off-by: TJ Zhang <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit 815e24c into valkey-io:main Jul 19, 2024
7 of 8 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/integ_tjz_geoadd branch July 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants