Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Update README #1944

Conversation

Yury-Fridlyand
Copy link
Collaborator

Reflect 1.0.1 release in readme

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client docs Documentation labels Jul 15, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner July 15, 2024 19:37
@barshaul
Copy link
Collaborator

@Yury-Fridlyand Is there an option to reflect the latest version of the client, so we won't need to rewrite the readme for each release?

Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge it but please in a separate PR please rewrite it so it would reflect the latest version rather than a specific one (if possible)

@Yury-Fridlyand
Copy link
Collaborator Author

I think I can add a CI which triggered by a new release published (release, not a tag). This CI will update all readmes using sed with regex, bump the version and create a PR.
I added a task to do that in our backlog.

@Yury-Fridlyand Yury-Fridlyand merged commit 5cf4e89 into valkey-io:main Jul 16, 2024
6 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/yuryf_update_release_version_in_readme branch July 16, 2024 17:52
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jul 18, 2024
Update REDME

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Jul 20, 2024
Update REDME

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants