Node: add SUNION command #1919
Merged
Node: add SUNION command #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
force-pushed
the
node/integ_acongo_sunion
branch
from
a0d542b
to
57ef844
Compare
| @@ -94,7 +99,7 @@ | |||
| #### Fixes | |||
| * Python: fixing a bug with transaction exec ([#1796](https://github.com/valkey-io/valkey-glide/pull/1796)) | |||
|
|
|||
| ## 0.4.1 (2024-02-06) | |||
| ## 0.4.1 (2024-06-02) | |||
node/src/BaseClient.ts
Outdated
| * | ||
| * @remarks When in cluster mode, all `keys` must map to the same hash slot. | ||
| * @param keys - The keys of the sets. | ||
| * @returns A set of members which are present in at least one of the given sets. |
There was a problem hiding this comment.
Huh, looks like some commands have a "-" after the @returns and some don't.
There was a problem hiding this comment.
it would be better if they were consistent. But javadoc in VSCode adds the dash if it's missing:
There was a problem hiding this comment.
I found that VS code can render docs with and without dashes. I don't know the standard.
Agree, that we need to align that. Can you create a task please?
There was a problem hiding this comment.
Yep, created a task on our board
jonathanl-bq
approved these changes
Jul 10, 2024
acarbonetto
approved these changes
Jul 10, 2024
node/src/BaseClient.ts
Outdated
| * | ||
| * @remarks When in cluster mode, all `keys` must map to the same hash slot. | ||
| * @param keys - The keys of the sets. | ||
| * @returns A set of members which are present in at least one of the given sets. |
There was a problem hiding this comment.
I found that VS code can render docs with and without dashes. I don't know the standard.
Agree, that we need to align that. Can you create a task please?
aaron-congo
force-pushed
the
node/integ_acongo_sunion
branch
from
4f93dac
to
680f52a
Compare
Signed-off-by: aaron-congo <[email protected]>
aaron-congo
force-pushed
the
node/integ_acongo_sunion
branch
from
680f52a
to
013f400
Compare
Yury-Fridlyand
approved these changes
Jul 10, 2024
Signed-off-by: aaron-congo <[email protected]>
Yury-Fridlyand
approved these changes
Jul 12, 2024
jonathanl-bq
pushed a commit
to jonathanl-bq/glide-for-redis
that referenced
this pull request
Jul 12, 2024
* Node: add SUNION command Signed-off-by: aaron-congo <[email protected]>
Yury-Fridlyand
pushed a commit
to Yury-Fridlyand/valkey-glide
that referenced
this pull request
Jul 15, 2024
* Node: add SUNION command Signed-off-by: aaron-congo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/sunion/