Python: add XREADGROUP command #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
approved these changes
Jun 26, 2024
acarbonetto
approved these changes
Jun 26, 2024
| with pytest.raises(RequestError): | ||
| await redis_client.xgroup_del_consumer(string_key, group_name, consumer) |
There was a problem hiding this comment.
did you intend to delete the xgroup_del_consumer test case?
There was a problem hiding this comment.
It isn't actually deleted, it just looks like it is, Git is getting mixed up identifying the diffs. On line 5319 above the xgroup_del_consumer is labelled as a new added line, but it should really be labelled as replacing the line thats "deleted" here
There was a problem hiding this comment.
Got it... I missed the added line. Thanks.
jduo
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 28, 2024
* Python: add XREADGROUP command * Fix mypy error * PR suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/xreadgroup/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.