Python: add XGROUP CREATE and XGROUP DESTROY commands #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
Jun 25, 2024
yipin-chen
reviewed
Jun 25, 2024
| async def test_xgroup_create_xgroup_destroy( | ||
| self, redis_client: TRedisClient, cluster_mode, protocol, request | ||
| ): | ||
| key = get_random_string(10) |
There was a problem hiding this comment.
In XREAD, you use key1 = f"{{testKey}}:1-{get_random_string(10)}".
There was a problem hiding this comment.
I do find prefixing the keys with something unique to the test is helpful for debugging.
Same for group_name, etc.
There was a problem hiding this comment.
Yeah, that's because XREAD is a multi-key command, so the keys need to have the same hash tag in order to be mapped to the same hash slot. XGROUP CREATE/DESTROY are single-key commands so they do not have this requirement.
acarbonetto
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/xgroup-create/
https://redis.io/docs/latest/commands/xgroup-destroy/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.