Fix stream add tests #1618
Merged
Fix stream add tests #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/integ_acarbo_fix_xaddoptions_tests
branch
from
5da4e80
to
9e7d4eb
Compare
acarbonetto
commented
Jun 20, 2024
| Long.toString(5L), | ||
| "*" | ||
| }))); | ||
| new String[] {NO_MAKE_STREAM_REDIS_API, "id"}), |
There was a problem hiding this comment.
THIS bracket was missing... causing only the first test to run
There was a problem hiding this comment.
... And made spotless crazy once you add it
There was a problem hiding this comment.
that was the first sign...
jonathanl-bq
approved these changes
Jun 20, 2024
Yury-Fridlyand
approved these changes
Jun 20, 2024
| Long.toString(5L), | ||
| "*" | ||
| }))); | ||
| new String[] {NO_MAKE_STREAM_REDIS_API, "id"}), |
There was a problem hiding this comment.
... And made spotless crazy once you add it
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.