Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add LINSERT command #1544

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

aaron-congo
Copy link
Collaborator

@aaron-congo aaron-congo commented Jun 7, 2024

Issue #, if available:
N/A

Description of changes:
https://valkey.io/commands/linsert/

  • Inserts element in the list at key either before or after the pivot.
  • Policies: none (see here)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aaron-congo aaron-congo requested a review from a team as a code owner June 7, 2024 23:01
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment to fix the example

node/src/BaseClient.ts Outdated Show resolved Hide resolved
@acarbonetto acarbonetto merged commit da42822 into valkey-io:main Jun 11, 2024
7 of 8 checks passed
@acarbonetto acarbonetto deleted the node/integ_acongo_linsert branch June 11, 2024 01:22
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Node: add LINSERT command

* PR suggestions

* Use backticks for cross-references

* Fix doc

---------

Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants