Python: adds JSON.TOGGLE command #1184

shohamazon · 2024-03-26T15:50:40Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

CHANGELOG.md

glide-core/src/client/value_conversion.rs

python/python/tests/tests_redis_modules/test_json.py

Co-authored-by: Yury-Fridlyand <[email protected]>

glide-core/src/client/value_conversion.rs

barshaul · 2024-03-27T08:56:47Z

python/python/glide/constants.py

@@ -27,3 +27,7 @@
 # Otherwise, response will be : {Address : response , ... } with type of Dict[str, T].
 TClusterResponse = Union[T, Dict[str, T]]
 TSingleNodeRoute = Union[RandomNode, SlotKeyRoute, SlotIdRoute, ByAddressRoute]
+# When specifying legacy path (path doesn't start with `$`), response will be T
+# Otherwise, (when specifying JSONPath) , response will be List[Optional[T]].


(when specifying JSONPath) , => (when specifying JSONPath),
(remove redundant space)

python/python/glide/async_commands/redis_modules/json.py

barshaul · 2024-03-27T09:02:33Z

python/python/glide/async_commands/redis_modules/json.py

+
+    Examples:
+        >>> from glide import json as redisJson
+        >>> await json.set(client, "doc", "$", json.dumps({"bool": true , "nested": {"bool": false , "nested": {"bool": 10}}}))


Suggested change

>>> await json.set(client, "doc", "$", json.dumps({"bool": true , "nested": {"bool": false , "nested": {"bool": 10}}}))

>>> await redisJson.set(client, "doc", "$", json.dumps({"bool": true , "nested": {"bool": false , "nested": {"bool": 10}}}))

"OK"

python/python/glide/async_commands/redis_modules/json.py

barshaul · 2024-03-27T09:05:43Z

python/python/glide/async_commands/redis_modules/json.py

+            [False, True, None]  # Indicates successful toggling of the Boolean values at path '$.bool' in the key stored at `doc`.
+        >>> await redisJson.toggle(client, "doc", "bool")
+            True  # Indicates successful toggling of the Boolean value at path 'bool' in the key stored at `doc`.
+        >>> await redisJson.get(client, "doc", "$")


Suggested change

>>> await redisJson.get(client, "doc", "$")

>>> json.loads(await redisJson.get(client, "doc", "$"))

and then output it accordingly

barshaul · 2024-03-27T09:07:47Z

python/python/glide/async_commands/redis_modules/json.py

+        path (str): The JSONPath to specify.
+
+    Returns:
+        TJsonResponse[bool]: Returns an array of boolean replies for each path, with the new value (false or true), or None for JSON values matching the path that are not Boolean.


"for each path" is confusing as 'path' is a single value

You can also refer to TJsonResponse to get more info

barshaul · 2024-03-27T09:09:28Z

python/python/glide/async_commands/redis_modules/json.py

+
+    Returns:
+        TJsonResponse[bool]: Returns an array of boolean replies for each path, with the new value (false or true), or None for JSON values matching the path that are not Boolean.
+        If `path` doesn't start with `$` (legacy path syntax), returns the new value of the toggled value in `path`. Note that when sending legacy path syntax, the value at `path` must be a boolean value.


Note that when sending legacy path syntax, the value at path must be a boolean value.

instead, write that if X then returns error

barshaul · 2024-03-27T09:14:20Z

glide-core/src/client/value_conversion.rs

@@ -121,6 +122,46 @@ pub(crate) fn convert_to_expected_type(
        ExpectedReturnType::BulkString => Ok(Value::BulkString(
            from_owned_redis_value::<String>(value)?.into(),
        )),
+        ExpectedReturnType::JsonToggleReturnType => match value {
+            Value::Array(array) => {
+                let new_array: Result<Vec<_>, _> = array


Suggested change

let new_array: Result<Vec<_>, _> = array

let new_array: RedisResult<Vec<_>> = array

barshaul · 2024-03-27T09:16:16Z

glide-core/src/client/value_conversion.rs

+            Value::Array(array) => {
+                let new_array: Result<Vec<_>, _> = array
+                    .into_iter()
+                    .map(|arr| match arr {


arr -> item

barshaul · 2024-03-27T09:38:14Z

glide-core/src/client/value_conversion.rs

+
+                match new_array {
+                    Ok(values) => Ok(Value::Array(values)),
+                    Err(err) => Err(err),
+                }


Suggested change

match new_array {

Ok(values) => Ok(Value::Array(values)),

Err(err) => Err(err),

}

new_array.map(Value::Array)

barshaul · 2024-03-27T09:38:55Z

glide-core/src/client/value_conversion.rs

@@ -121,6 +122,46 @@ pub(crate) fn convert_to_expected_type(
        ExpectedReturnType::BulkString => Ok(Value::BulkString(
            from_owned_redis_value::<String>(value)?.into(),
        )),
+        ExpectedReturnType::JsonToggleReturnType => match value {
+            Value::Array(array) => {
+                let new_array: Result<Vec<_>, _> = array


new_array -> converted_array

barshaul · 2024-03-27T09:40:50Z

glide-core/src/client/value_conversion.rs

+                    Err(err) => Err(err),
+                }
+            }
+            Value::BulkString(s) => match std::str::from_utf8(&s) {


Suggested change

Value::BulkString(s) => match std::str::from_utf8(&s) {

Value::BulkString(bytes) => match std::str::from_utf8(&bytes) {

shohamazon requested a review from a team as a code owner March 26, 2024 15:50

Python: adds JSON.TOGGLE command

88b51b1

shohamazon force-pushed the python/json.toggle branch from 46fdd82 to 88b51b1 Compare March 26, 2024 15:52

shohamazon added the python label Mar 26, 2024

shohamazon requested review from barshaul, shachlanAmazon, ikolomi and avifenesh March 26, 2024 15:53

Yury-Fridlyand approved these changes Mar 26, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

glide-core/src/client/value_conversion.rs Outdated Show resolved Hide resolved

python/python/tests/tests_redis_modules/test_json.py Outdated Show resolved Hide resolved

Update CHANGELOG.md

4198889

Co-authored-by: Yury-Fridlyand <[email protected]>

shohamazon commented Mar 26, 2024

View reviewed changes

glide-core/src/client/value_conversion.rs Outdated Show resolved Hide resolved

Update glide-core/src/client/value_conversion.rs

f009815

barshaul reviewed Mar 27, 2024

View reviewed changes

python/python/glide/async_commands/redis_modules/json.py Show resolved Hide resolved

barshaul reviewed Mar 27, 2024

View reviewed changes

python/python/glide/async_commands/redis_modules/json.py Show resolved Hide resolved

barshaul reviewed Mar 27, 2024

View reviewed changes

barshaul approved these changes Mar 27, 2024

View reviewed changes

fix documentation

08f3b91

shohamazon merged commit faca726 into valkey-io:main Mar 27, 2024
45 checks passed

shohamazon deleted the python/json.toggle branch March 27, 2024 10:36

shohamazon added a commit to adanWattad/glide-for-redis that referenced this pull request Apr 9, 2024

Python: adds JSON.TOGGLE command (valkey-io#1184)

f419d2c

cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024

Python: adds JSON.TOGGLE command (valkey-io#1184)

9323c36

shohamazon mentioned this pull request Oct 28, 2024

Json module for Python #645

Open

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python: adds JSON.TOGGLE command #1184

Python: adds JSON.TOGGLE command #1184

shohamazon commented Mar 26, 2024

barshaul Mar 27, 2024

barshaul Mar 27, 2024 •

edited

Loading

barshaul Mar 27, 2024

barshaul Mar 27, 2024

barshaul Mar 27, 2024

barshaul Mar 27, 2024

barshaul Mar 27, 2024

barshaul Mar 27, 2024 •

edited

Loading

barshaul Mar 27, 2024

barshaul Mar 27, 2024

barshaul Mar 27, 2024

	>>> await json.set(client, "doc", "$", json.dumps({"bool": true , "nested": {"bool": false , "nested": {"bool": 10}}}))
	>>> await redisJson.set(client, "doc", "$", json.dumps({"bool": true , "nested": {"bool": false , "nested": {"bool": 10}}}))
	"OK"

	>>> await redisJson.get(client, "doc", "$")
	>>> json.loads(await redisJson.get(client, "doc", "$"))

	let new_array: Result<Vec<_>, _> = array
	let new_array: RedisResult<Vec<_>> = array

	Value::BulkString(s) => match std::str::from_utf8(&s) {
	Value::BulkString(bytes) => match std::str::from_utf8(&bytes) {

Python: adds JSON.TOGGLE command #1184

Python: adds JSON.TOGGLE command #1184

Conversation

shohamazon commented Mar 26, 2024

Choose a reason for hiding this comment

barshaul Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barshaul Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

barshaul Mar 27, 2024 •

edited

Loading

barshaul Mar 27, 2024 •

edited

Loading