Refactored validation part #152
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #152 +/- ##
======================================
Coverage 100% 100%
======================================
Files 38 39 +1
Lines 784 763 -21
======================================
- Hits 784 763 -21
Continue to review full report at Codecov.
|
| { | ||
| rules.ThrowIfNull(); | ||
|
|
||
| var result = ValitResult.Success; |
There was a problem hiding this comment.
This seems like an enum to me, maybe it would be clearer to do new ValitResult()?
There was a problem hiding this comment.
You can always hover on var so it's clear that's IValitStrategy object :D
|
|
||
| if(!result.Succeeded) | ||
| { | ||
| strategy.Fail(rule, result, out bool cancel); |
There was a problem hiding this comment.
I think I said this a couple of days ago, but maybe lets make strategy.Fail return a bool?
There was a problem hiding this comment.
@arekbal did this as an out param. I think he's the right person to ask why we actualy use it :D
There was a problem hiding this comment.
Cleaner API when implementing that method. Instead of guessing or going through some docs to find why method returns bool and what it means(true for cancel or continue?), one just implements a method with clear declaration.
Info
This Pull Request is related to issue no. #150
With some hard time for figuring out how to make it better but I did it :D !
Changes
ValitRuleExtensionsclass withVallidateRules()extensionIValitRules<TObject>CollectionValitRuleNestedObjectCollectionValitRul