Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ghana phone numbers validation #922

Closed
wants to merge 4 commits into from
Closed

Add Ghana phone numbers validation #922

wants to merge 4 commits into from

Conversation

aberba
Copy link
Contributor

@aberba aberba commented Oct 31, 2018

This will add support for validating all Ghana phone numbers.

Add tests for Ghana phone codes
Add Ghana phone number validation regex
add Ghana phone code
@chriso
Copy link
Collaborator

chriso commented Nov 3, 2018

Thanks for the PR 😄

Could you fix the lint errors?

@chriso chriso added the 🧹 needs-update For PRs that need to be updated before landing label Nov 3, 2018
@aberba
Copy link
Contributor Author

aberba commented Nov 3, 2018

Hello, my text edit doesn't have such linting rules and I honestly can't figure out how to go about it ATM. Can you fix that at your end?

@chriso
Copy link
Collaborator

chriso commented Nov 7, 2018

See #927.

@chriso chriso closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants