Greece and Cyprus alpha and mobile added. #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you update the README and add some tests? |
|
@savvakism any update? |
|
@chriso - is it just tests remaining and this will be good to go? Can give @savvakism few more days and I can jump in to help if we don't get any response. |
|
@profnandaa correct – looks good, just missing tests and a README entry. |
|
looks good |
andela-anandaa
pushed a commit
to profnandaa/validator.js
that referenced
this pull request
Dec 8, 2017
This commit adds minor fixes on the PR validatorjs#679 completing alpha, alphanumeric and mobile-phone features for Greece.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greek and Cypriot alpha, alphanumeric and mobile numbers support.