Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isUUID)!: fully support rfc9562 #2421

Merged
merged 1 commit into from
Jun 22, 2024
Merged

fix(isUUID)!: fully support rfc9562 #2421

merged 1 commit into from
Jun 22, 2024

Conversation

broofa
Copy link
Contributor

@broofa broofa commented Jun 13, 2024

PR for #2419.

Note that this will be a BREAKING CHANGE for the following reasons:

  • isUUID(str, version) will now return false if str does not have a valid variant field. (Previously only versions 4, 5, and 7 enforced this field.)
  • isUUID(str, 'all') now only allows RFC9562 UUIDS. Previously it would accept any string that looked UUID-ish ("xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"), regardless of what values were in the version or variant fields.

provide some (credible) references showing the structure of the data to be validated, if applicable

New UUID values were generated with the uuid utility. E.g. npx uuid v6. Also, I maintain the uuid module so... 🤷

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin
Copy link
Member

rubiin commented Jun 22, 2024

@profnandaa this is a critical fix considering we were allowing invalid uuids in the past

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@profnandaa profnandaa merged commit 89e856c into validatorjs:master Jun 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants