Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update README.md for installation with other package managers #2402

Merged
merged 1 commit into from
Jun 1, 2024
Merged

doc: Update README.md for installation with other package managers #2402

merged 1 commit into from
Jun 1, 2024

Conversation

BibhushanKarki
Copy link
Contributor

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

profnandaa
profnandaa approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have preferred adding "either of the following"?

@rubiin rubiin merged commit 806e55e into validatorjs:master Jun 1, 2024
10 checks passed
@rubiin
Copy link
Member

rubiin commented Jun 1, 2024

I will be merging this for now

@profnandaa
Copy link
Member

@rubiin -- can be squash-merging instead, there should be that option on your end?

@rubiin
Copy link
Member

rubiin commented Jun 1, 2024

yeah but figured that would be an issue as the pr has single commit

@profnandaa
Copy link
Member

I meant this one:
image

it the preferred approach to, "Merge pull request ..." commit messages....

@rubiin
Copy link
Member

rubiin commented Jun 3, 2024

oh gotcha

1 similar comment
@rubiin
Copy link
Member

rubiin commented Jun 3, 2024

oh gotcha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@rubiin rubiin rubiin approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
✅ LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BibhushanKarki @rubiin @profnandaa @WikiRik