Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(isMailtoURI): remove unnecessary default to #2341

Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 24, 2023

Line 44 is only partially covered before this change. This PR hopes to change that so the newly open PRs don't fail codecov/project.
Splitting a query always returned at least 1, so the case where the first element (to) was empty couldn't get hit by tests (at least not in our current test setup where we only test strings).

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Line 44 is only partially covered before this change
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (15f83b0) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #2341      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files         107       107              
  Lines        2454      2449       -5     
  Branches      619       619              
===========================================
- Hits         2453      2449       -4     
+ Partials        1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WikiRik WikiRik changed the title chore: add additional testcases to isMailtoURI chore(isMailtoURI): remove unnecessary default to Nov 24, 2023
@WikiRik WikiRik marked this pull request as ready for review November 24, 2023 21:14
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@profnandaa profnandaa merged commit 4197b86 into validatorjs:master Mar 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants