-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(isMailtoURI): remove unnecessary default to #2341
Merged
profnandaa
merged 6 commits into
validatorjs:master
from
WikiRik:WikiRik/add-mailtouri-testcases
Mar 5, 2024
Merged
chore(isMailtoURI): remove unnecessary default to #2341
profnandaa
merged 6 commits into
validatorjs:master
from
WikiRik:WikiRik/add-mailtouri-testcases
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 44 is only partially covered before this change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2341 +/- ##
===========================================
+ Coverage 99.95% 100.00% +0.04%
===========================================
Files 107 107
Lines 2454 2449 -5
Branches 619 619
===========================================
- Hits 2453 2449 -4
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
WikiRik
changed the title
chore: add additional testcases to isMailtoURI
chore(isMailtoURI): remove unnecessary default to
Nov 24, 2023
rubiin
approved these changes
Nov 25, 2023
4 tasks
profnandaa
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 44 is only partially covered before this change. This PR hopes to change that so the newly open PRs don't fail codecov/project.
Splitting a query always returned at least 1, so the case where the first element (
to
) was empty couldn't get hit by tests (at least not in our current test setup where we only test strings).Checklist