Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Saint Martin (French) mobile number validation #2297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0APOCALYPSE0
Copy link

@0APOCALYPSE0 0APOCALYPSE0 commented Oct 1, 2023

Added validation for Saint Martin (French) on isMobilePhone. referred issue: #1761
Source: https://en.wikipedia.org/wiki/Collectivity_of_Saint_Martin

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (10e7790) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2297      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              
Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0APOCALYPSE0
Copy link
Author

Hi, I am new to codecov. Can anybody help me here to pass codecov/project check?
Thanks

added more valid saint martin mobile numbers for test cases

added more invalid saint martin mobile numbers for test case
@0APOCALYPSE0
Copy link
Author

@WikiRik Hi, Could you please review and approve my PR?
Thanks

@0APOCALYPSE0
Copy link
Author

0APOCALYPSE0 commented Sep 28, 2024

Please approve this PR on Oct 1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants