-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: split tests of various validators #2159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2334 2334
Branches 586 586
=========================================
Hits 2334 2334 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer that you split out the huge ones that keep changing often first, e.g. isMobilePhone
. Huge here is any validator perhaps with >100 locs?
For But I will see about other large validators soon, thanks for the comment! |
This PR splits tests for 15 validators from the big file to individual files. All of these validators should not have open PRs that would need rebasing after merging this. Organization members can look at this project to see which PR affects which validator.
Additional PRs with the same goal will follow in the future but I'm starting with this to make the review process relatively easy.
Checklist