Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split tests of various validators #2159

Closed
wants to merge 16 commits into from

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Jan 30, 2023

This PR splits tests for 15 validators from the big file to individual files. All of these validators should not have open PRs that would need rebasing after merging this. Organization members can look at this project to see which PR affects which validator.

Additional PRs with the same goal will follow in the future but I'm starting with this to make the review process relatively easy.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6dba289) to head (983fd64).
Report is 103 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2334      2334           
  Branches       586       586           
=========================================
  Hits          2334      2334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that you split out the huge ones that keep changing often first, e.g. isMobilePhone. Huge here is any validator perhaps with >100 locs?

@WikiRik
Copy link
Member Author

WikiRik commented Feb 8, 2023

For isMobilePhone specifically; when I made this PR there were about 50 open PRs for that. So I thought that would cause too many merge conflicts. But once we go through those and the open PRs left are outdated or merged I can work on splitting isMobilePhone away.

But I will see about other large validators soon, thanks for the comment!

@WikiRik WikiRik closed this by deleting the head repository Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants