-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change test files to prepare for #1874 #2091
refactor: change test files to prepare for #1874 #2091
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2091 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2335 2335
Branches 586 586
=========================================
Hits 2335 2335 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@pixelbucket-dev could you rebase on this? I've already updated the refactor of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Would be really nice if we could merge this! That makes it a lot easier to review PRs like #2089 |
@WikiRik mc is blocking the merge |
@rubiin Fixed, thanks for the heads up! I'll review the PRs that allow usage of the options object after this has been merged and those PRs have been rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
This PR takes away some of the changes in #2075 and related PRs built on that which are needed to implement #1874. This way the PRs that build on this do not have unrelated changes to
isAfter
.Checklist