Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isTaxID implementation, test cases and updated readme for 'en-IN' #2032

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajinkyac03
Copy link

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #2032 (8502d26) into master (86a07ba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2032   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           
Impacted Files Coverage Δ
src/lib/isTaxID.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

'AAAAA1111A',
'BBBBB1111B',
'CCCCC1111C',
'FFFFF1111F'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'FFFFF1111F'],
'FFFFF0001F',
'ZZZFZ9999Z'],

Nice to make sure that the entire number range is correctly validated :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@braaar I have updated the test cases for entire number range validation.

test/validators.js Outdated Show resolved Hide resolved
@ajinkyac03
Copy link
Author

@braaar anything more needed from my end?

@braaar
Copy link
Contributor

braaar commented Sep 13, 2022

No, I don't think so. We just have to wait for maintainer review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new identity card validator for the Indian PAN card
3 participants