-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added isTaxID implementation, test cases and updated readme for 'en-IN' #2032
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2032 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2203 2203
Branches 477 477
=========================================
Hits 2203 2203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
test/validators.js
Outdated
'AAAAA1111A', | ||
'BBBBB1111B', | ||
'CCCCC1111C', | ||
'FFFFF1111F'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'FFFFF1111F'], | |
'FFFFF0001F', | |
'ZZZFZ9999Z'], |
Nice to make sure that the entire number range is correctly validated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@braaar I have updated the test cases for entire number range validation.
@braaar anything more needed from my end? |
No, I don't think so. We just have to wait for maintainer review. |
Checklist