Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Changes made' from README #2024

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Aug 10, 2022

Added in #1678 without specific reason

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Added in validatorjs#1678 without specific reason
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2024 (e143430) into master (86a07ba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@WikiRik
Copy link
Member Author

WikiRik commented Oct 19, 2022

@rubiin not sure if you've seen this one before, but might be nice to remove this line before the next release

@rubiin
Copy link
Member

rubiin commented Oct 19, 2022

LGTM

@rubiin rubiin merged commit 531dc7f into validatorjs:master Oct 19, 2022
@WikiRik WikiRik deleted the patch-1 branch October 19, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants