Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, fa, fa-IR, fa-AF based on cldr #1411

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Fix, fa, fa-IR, fa-AF based on cldr #1411

merged 2 commits into from
Aug 19, 2020

Conversation

mhf-ir
Copy link
Contributor

@mhf-ir mhf-ir commented Aug 17, 2020

Cldr process script
https://gist.github.com/mhf-ir/04a6fc43c8f931b0d0cfa1dc02730c1b

Characters:
https://github.com/unicode-cldr/cldr-misc-modern/blob/master/main/fa/characters.json#L10
Default country for fa is IR
https://github.com/unicode-cldr/cldr-core/blob/master/defaultContent.json#L52

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1411 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1411   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         1248      1254    +6     
=========================================
+ Hits          1248      1254    +6     
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed86b0a...65db5ec. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contrib! 🎉
/cc. @tux-tn @ezkemboi

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
great work @mhf-ir 🎉

@mikeerickson
Copy link

Thanks for all the efforts on this, I will get it reviewed as soon as possible.

@profnandaa profnandaa merged commit 28f7f65 into validatorjs:master Aug 19, 2020
@profnandaa profnandaa mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants